Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Sign rulesets - #15063

Merged
Hainish merged 24 commits into
masterfrom
sign-rulesets
Apr 3, 2018
Merged

Hainish merged 24 commits into
masterfrom
sign-rulesets

Conversation

@Hainish

@Hainish Hainish commented Apr 3, 2018

Copy link
Copy Markdown
Member

No description provided.

Hainish added 23 commits March 30, 2018 14:18
previously be able to switch `default.rulesets.gz` with an old signed
ruleset file.  We now combine the fact that the JavaScript checks that
`latest-rulesets-timestamp` has a greater value than what is currently
stored *and*, vitally, that it matches the timestamp bundled with the
signed ruleset file.
Comment thread chromium/background-scripts/update.js Outdated

// how often we should check for new rulesets
const periodicity = 10;
const periodicity = 7200;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hainish isn't this just 2 hours instead of 2 days in seconds?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're definitely right! Thank you.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's those little bugs which are killers. Glad you caught that.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

033f82d looks good to me, thanks! 😄

@Hainish

Hainish commented Apr 3, 2018

Copy link
Copy Markdown
Member Author

This has been available for review and reviewed by a few people now.

I'll be merging this tomorrow morning, and making a release in the afternoon.

@Hainish
Hainish merged commit 21455e8 into master Apr 3, 2018
@Hainish
Hainish deleted the sign-rulesets branch April 3, 2018 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants